Skip to content

Commit

Permalink
Fixed experience cards issue on safari (saadpasta#201)
Browse files Browse the repository at this point in the history
* Fixed issue where images and content were overlapping on safari experience card

* Added pngs for logos as webp is currently not supported on safari

* Removed webp logos in favor of PNG
  • Loading branch information
abhishekashyap authored Jul 3, 2020
1 parent ec4f107 commit 15dd996
Show file tree
Hide file tree
Showing 9 changed files with 5 additions and 34 deletions.
31 changes: 0 additions & 31 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added src/assets/images/airbnbLogo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/assets/images/airbnbLogo.webp
Binary file not shown.
Binary file added src/assets/images/facebookLogo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/assets/images/facebookLogo.webp
Binary file not shown.
Binary file added src/assets/images/quoraLogo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/assets/images/quoraLogo.webp
Binary file not shown.
2 changes: 2 additions & 0 deletions src/components/experienceCard/ExperienceCard.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.experience-card {
position: relative;
background-color: rgb(255, 255, 255);
box-shadow: rgba(0, 0, 0, 0.2) 0px 10px 30px -15px;
border-radius: 10px;
Expand Down Expand Up @@ -68,6 +69,7 @@

.experience-roundedimg {
position: absolute;
object-fit: cover;
left: 0;
right: 0;
top: 7rem;
Expand Down
6 changes: 3 additions & 3 deletions src/portfolio.js
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const workExperiences = {
{
role: "Software Engineer",
company: "Facebook",
companylogo: require("./assets/images/facebookLogo.webp"),
companylogo: require("./assets/images/facebookLogo.png"),
date: "June 2018 – Present",
desc: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.",
descBullets: [
Expand All @@ -135,14 +135,14 @@ const workExperiences = {
{
role: "Front-End Developer",
company: "Quora",
companylogo: require("./assets/images/quoraLogo.webp"),
companylogo: require("./assets/images/quoraLogo.png"),
date: "May 2017 – May 2018",
desc: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
},
{
role: "Software Engineer Intern",
company: "Airbnb",
companylogo: require("./assets/images/airbnbLogo.webp"),
companylogo: require("./assets/images/airbnbLogo.png"),
date: "Jan 2015 – Sep 2015",
desc: "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
},
Expand Down

0 comments on commit 15dd996

Please sign in to comment.