Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace pow with stdlib_base_pow #6369

Merged
merged 4 commits into from
Mar 29, 2025
Merged

chore: replace pow with stdlib_base_pow #6369

merged 4 commits into from
Mar 29, 2025

Conversation

anandkaranubc
Copy link
Contributor

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • Replaces pow with stdlib_base_pow

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@anandkaranubc
chore: replace pow with stdlib equivalent
52f41e5 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 25, 2025
@anandkaranubc
chore: remove math.h include
63d731e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 25, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/floorn $\color{green}272/272$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}272/272$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gunjjoshi
Copy link
Member

gunjjoshi commented Mar 26, 2025 •
edited by anandkaranubc
Loading

@anandkaranubc Can you please rename floorn.c to main.c, and subsequently modify manifest.json too, so that it adheres to the latest conventions?

@anandkaranubc
Copy link
Contributor Author

@anandkaranubc Can you please rename floorn.c to main.c, and subsequently modify manifest.json too, so that it adheres to the latest conventions?

Sure! On it...

@anandkaranubc anandkaranubc marked this pull request as draft March 26, 2025 06:03
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 26, 2025
@anandkaranubc
chore: rename C file
8b8e311 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc anandkaranubc marked this pull request as ready for review March 26, 2025 06:05
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 26, 2025
gunjjoshi
gunjjoshi previously approved these changes Mar 26, 2025
View reviewed changes
Planeshifter
Planeshifter previously approved these changes Mar 29, 2025
View reviewed changes
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 29, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 29, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 29, 2025 •
edited by Planeshifter
Loading

PR Commit Message

refactor: replace `pow` with `stdlib_base_pow`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6369

Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter dismissed stale reviews from gunjjoshi and themself via fe2cfd4 March 29, 2025 16:38
@Planeshifter Planeshifter merged commit 3408293 into stdlib-js:develop Mar 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@gunjjoshi gunjjoshi gunjjoshi left review comments

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandkaranubc @stdlib-bot @gunjjoshi @Planeshifter