Skip to content

Commit

Permalink
target-mips: Activate IEEE 754-2008 signaling NaN bit meaning for MSA
Browse files Browse the repository at this point in the history
Function msa_reset() is updated so that flag snan_bit_is_one is
properly set to 0.

By applying this patch, a number of incorrect MSA behaviors that
require IEEE 754-2008 compliance will be fixed. Those are behaviors
that (up to the moment of applying this patch) did not get the desired
functionality from SoftFloat library with respect to distinguishing
between quiet and signaling NaN, getting default NaN values (both
quiet and signaling), establishing if a floating point number is NaN
or not, etc.

Two examples:

* FMAX, FMIN will now correctly detect and propagate NaNs.
* FCLASS.D ans FCLASS.S will now correcty detect NaN flavors.

Signed-off-by: Aleksandar Markovic <[email protected]>
Reviewed-by: Leon Alrae <[email protected]>
Signed-off-by: Leon Alrae <[email protected]>
  • Loading branch information
aleksandar-markovic authored and Leon Alrae committed Jun 24, 2016
1 parent 52d4c8e commit 40bd6dd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion target-mips/translate_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -893,5 +893,6 @@ static void msa_reset(CPUMIPSState *env)
/* clear float_status nan mode */
set_default_nan_mode(0, &env->active_tc.msa_fp_status);

set_snan_bit_is_one(1, &env->active_tc.msa_fp_status);
/* set proper signanling bit meaning ("1" means "quiet") */
set_snan_bit_is_one(0, &env->active_tc.msa_fp_status);
}

0 comments on commit 40bd6dd

Please sign in to comment.