Skip to content

Commit

Permalink
linux-user: Fix certain argument alignment cases for Mips64
Browse files Browse the repository at this point in the history
The function that is changed in this patch is supposed to indicate that
there was certain argument rearrangement related to 64-bit arguments on
32-bit platforms. The background on such rearrangements can be found,
for example, in the man page for syscall(2).

However, for 64-bit Mips architectures there is no such rearrangement,
and this patch reflects it.

Signed-off-by: Aleksandar Rikalo <[email protected]>
Signed-off-by: Aleksandar Markovic <[email protected]>
Reviewed-by: Laurent Vivier <[email protected]>
Reviewed-by: Leon Alrae <[email protected]>
Acked-by: Riku Voipio <[email protected]>
Signed-off-by: Leon Alrae <[email protected]>
  • Loading branch information
aleksandar-markovic authored and Leon Alrae committed Sep 23, 2016
1 parent 2ef4186 commit d7779ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion linux-user/syscall.c
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ static inline int next_free_host_timer(void)
static inline int regpairs_aligned(void *cpu_env) {
return ((((CPUARMState *)cpu_env)->eabi) == 1) ;
}
#elif defined(TARGET_MIPS)
#elif defined(TARGET_MIPS) && (TARGET_ABI_BITS == 32)
static inline int regpairs_aligned(void *cpu_env) { return 1; }
#elif defined(TARGET_PPC) && !defined(TARGET_PPC64)
/* SysV AVI for PPC32 expects 64bit parameters to be passed on odd/even pairs
Expand Down

0 comments on commit d7779ac

Please sign in to comment.