Fixed Parser so that this Expression can work with ProvidePlugin

steintore · Feb 27, 2018 · 1ab9fdb · 1ab9fdb
1 parent 5044762
commit 1ab9fdb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/Parser.js b/lib/Parser.js
@@ -2008,7 +2008,7 @@ class Parser extends Tapable {
 			free = true;
 			exprName.push(this.scope.renames.get("this"));
 		} else if (expr.type === "ThisExpression") {
-			free = false;
+			free = this.scope.topLevelScope;
 			exprName.push("this");
 		} else {
 			return null;

diff --git a/test/configCases/plugins/provide-plugin/index.js b/test/configCases/plugins/provide-plugin/index.js
@@ -16,6 +16,10 @@ it("should provide a module for a nested var within a IIFE's argument", function
 	}(process));
 });
 
+it("should provide a module for thisExpression", () => {
+	(this.aaa).should.be.eql("aaa");
+});
+
 it("should provide a module for a nested var within a IIFE's this", function() {
 	(function() {
 		(this.env.NODE_ENV).should.be.eql("development");

diff --git a/test/configCases/plugins/provide-plugin/webpack.config.js b/test/configCases/plugins/provide-plugin/webpack.config.js
@@ -9,7 +9,8 @@ module.exports = {
 			es2015: "./harmony",
 			es2015_name: ["./harmony", "default"],
 			es2015_alias: ["./harmony", "alias"],
-			es2015_year: ["./harmony", "year"]
+			es2015_year: ["./harmony", "year"],
+			"this.aaa": "./aaa"
 		})
 	]
 };