Add requested changes from PR comments

steintore · Mar 5, 2018 · 57c6c43 · 57c6c43
1 parent fc0b327
commit 57c6c43
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/lib/WebpackOptionsDefaulter.js b/lib/WebpackOptionsDefaulter.js
@@ -129,7 +129,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 		});
 		this.set("output.devtoolNamespace", "make", options => {
 			if (Array.isArray(options.output.library))
-				return [].concat(options.output.library).join(".");
+				return options.output.library.join(".");
 			return options.output.library || "";
 		});
 		this.set("output.libraryTarget", "var");

diff --git a/test/configCases/source-map/array-as-output-library/index.js b/test/configCases/source-map/array-as-output-library/index.js
@@ -0,0 +1 @@
+it("should compile successfully when output.library is an array of strings", function() {});
diff --git a/test/configCases/source-map/array-as-output-library/webpack.config.js b/test/configCases/source-map/array-as-output-library/webpack.config.js
@@ -0,0 +1,7 @@
+module.exports = {
+	devtool: "source-map",
+	output: {
+		filename: "MyLibrary.[name].js",
+		library: ["Foo", "[name]"]
+	}
+};
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		it("should compile successfully when output.library is an array of strings", function() {});