Add Trezor hardware wallet #538
Conversation
quietbits
commented
Jul 7, 2021
quietbits
commented
|
Preview is available here: |
| /** | ||
| * Transforms StellarSdk.Transaction to TrezorConnect.StellarTransaction | ||
| */ | ||
| export const transformTransaction = (path, transaction) => { |
There was a problem hiding this comment.
I think it would be helpful to call this trezorTransformTransaction so when you call this in transactionSigner it's clear that this is specifically for Trezor
| return "createPassiveOffer"; | ||
| case "manageSellOffer": | ||
| // case 'manageBuyOffer': | ||
| return "manageOffer"; |
There was a problem hiding this comment.
out of scope for this PR, but we should implement an enum here during the Lab refactor
There was a problem hiding this comment.
We could refactor this but it might be better to keep it as close to the original created by Trezor as possible. Just in case there are updates. Aside from added types and some minor adjustments, it's pretty close to the original.
|
Preview is available here: |
|
Preview is available here: |
|
@quietbits Testing pass SUCCESS. Ready to merge. |
