-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pickers #55
Refactor pickers #55
Conversation
@@ -17,11 +17,11 @@ export function changePendingRequestProps(props) { | |||
} | |||
|
|||
export const UPDATE_VALUES = "UPDATE_VALUES"; | |||
export function updateValues(param, values) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this action is becoming single-valued, you should reflect it in the name as well: UPDATE_VALUE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I should've been using "values" instead of "value" in the first place.
You've copy-pasted the same markup for a "text box with validation" too many times for me to endorse this change. Instead, I think you should add export default function SecretKeyPicker(props) {
return <TextPicker
{...props}
placeholder={'Example: SAEXAMPLE6TLGEF6ASOTVTLFUK7LE2K2PFVPFGTEZMMVHH7KLLBBROEQ'}
validator={validator}
/>
} |
Other than the copy-pasta, +1 |
Thanks for the useful feedback! |
This PR is a refactor of the Pickers driven by data and the PickerGenerator. This replaces it with a more code-based approach to it.
This also makes pages in the Laboratory persistent between app page change. #44