fix transaction sequence number bug caused by using JS Number #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ |
irisli
added a commit
that referenced
this pull request
Jan 26, 2016
fix transaction sequence number bug caused by using JS Number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New accounts on the testnet are now created with a starting sequence number greater the native JavaScript Number max number. A new account I created on testnet had the sequence of 9048748768362496 where as the javascript max functional
Number.MAX_SAFE_INTEGERis 9007199254740991 which is LESS than the sequence number of new accounts.There was a bug in the laboratory and in js-stellar-base that relied on the insufficient
Numbernative value in JavaScript.