Fix resource leaks in the tests

stephenyik · Jul 18, 2013 · 7215c01 · 7215c01
1 parent 8828d53
commit 7215c01
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/codec/src/test/java/io/netty/handler/codec/frame/LengthFieldBasedFrameDecoderTest.java b/codec/src/test/java/io/netty/handler/codec/frame/LengthFieldBasedFrameDecoderTest.java
@@ -64,6 +64,7 @@ public void testFailFastTooLongFrameRecovery() throws Exception {
             ch.writeInbound(Unpooled.wrappedBuffer(new byte[] { 0, 0, 0, 0, 0, 1, 'A' }));
             ByteBuf buf = (ByteBuf) ch.readInbound();
             assertEquals("A", buf.toString(CharsetUtil.ISO_8859_1));
+            buf.release();
         }
     }
 }
diff --git a/codec/src/test/java/io/netty/handler/codec/frame/LengthFieldPrependerTest.java b/codec/src/test/java/io/netty/handler/codec/frame/LengthFieldPrependerTest.java
@@ -40,21 +40,27 @@ public void setUp() throws Exception {
     public void testPrependLength() throws Exception {
         final EmbeddedChannel ch = new EmbeddedChannel(new LengthFieldPrepender(4));
         ch.writeOutbound(msg);
-        assertThat((ByteBuf) ch.readOutbound(), is(wrappedBuffer(new byte[]{0, 0, 0, 1, 'A'})));
+        final ByteBuf buf = (ByteBuf) ch.readOutbound();
+        assertThat(buf, is(wrappedBuffer(new byte[]{0, 0, 0, 1, 'A'})));
+        buf.release();
     }
 
     @Test
     public void testPrependLengthIncludesLengthFieldLength() throws Exception {
         final EmbeddedChannel ch = new EmbeddedChannel(new LengthFieldPrepender(4, true));
         ch.writeOutbound(msg);
-        assertThat((ByteBuf) ch.readOutbound(), is(wrappedBuffer(new byte[]{0, 0, 0, 5, 'A'})));
+        final ByteBuf buf = (ByteBuf) ch.readOutbound();
+        assertThat(buf, is(wrappedBuffer(new byte[]{0, 0, 0, 5, 'A'})));
+        buf.release();
     }
 
     @Test
     public void testPrependAdjustedLength() throws Exception {
         final EmbeddedChannel ch = new EmbeddedChannel(new LengthFieldPrepender(4, -1));
         ch.writeOutbound(msg);
-        assertThat((ByteBuf) ch.readOutbound(), is(wrappedBuffer(new byte[]{0, 0, 0, 0, 'A'})));
+        final ByteBuf buf = (ByteBuf) ch.readOutbound();
+        assertThat(buf, is(wrappedBuffer(new byte[]{0, 0, 0, 0, 'A'})));
+        buf.release();
     }
 
     @Test