resource leak: FileInputStream was never closed

stephenyik · Aug 14, 2013 · 9acf130 · 9acf130
1 parent 65fd9c0
commit 9acf130
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/example/src/main/java/io/netty/example/filetransfer/FileServer.java b/example/src/main/java/io/netty/example/filetransfer/FileServer.java
@@ -101,9 +101,11 @@ public void channelRead0(ChannelHandlerContext ctx, String msg) throws Exception
                     return;
                 }
                 ctx.write(file + " " + file.length() + '\n');
-                FileRegion region = new DefaultFileRegion(new FileInputStream(file).getChannel(), 0, file.length());
+                FileInputStream fis = new FileInputStream(file);
+                FileRegion region = new DefaultFileRegion(fis.getChannel(), 0, file.length());
                 ctx.write(region);
                 ctx.writeAndFlush("\n");
+                fis.close();
             } else {
                 ctx.writeAndFlush("File not found: " + file + '\n');
             }