Skip to content

Commit

Permalink
SCEV validator: Ignore CouldNotCompute/undef on both sides. This is m…
Browse files Browse the repository at this point in the history
…ostly noise and blocks finding more severe bugs.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@166873 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
d0k committed Oct 27, 2012
1 parent cb8b8ea commit 974d98d
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions lib/Analysis/ScalarEvolution.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7005,15 +7005,18 @@ void ScalarEvolution::verifyAnalysis() const {

// Compare the stringified SCEVs. We don't care if undef backedgetaken count
// changes.
// FIXME: We currently ignore SCEV changes towards CouldNotCompute. This
// FIXME: We currently ignore SCEV changes from/to CouldNotCompute. This
// means that a pass is buggy or SCEV has to learn a new pattern but is
// usually not harmful.
if (OldI->second != NewI->second &&
OldI->second.find("undef") == std::string::npos &&
NewI->second.find("undef") == std::string::npos &&
OldI->second != "***COULDNOTCOMPUTE***" &&
NewI->second != "***COULDNOTCOMPUTE***") {
dbgs() << "SCEVValidator: SCEV for Loop '"
dbgs() << "SCEVValidator: SCEV for loop '"
<< OldI->first->getHeader()->getName()
<< "' from '" << OldI->second << "' to '" << NewI->second << "'!";
<< "' changed from '" << OldI->second
<< "' to '" << NewI->second << "'!\n";
std::abort();
}
}
Expand Down

0 comments on commit 974d98d

Please sign in to comment.