Skip to content

Commit

Permalink
minor symfony#29174 Add required key attribute (greg0ire)
Browse files Browse the repository at this point in the history
This PR was merged into the 2.8 branch.

Discussion
----------

Add required key attribute

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

I am getting warnings when running tests with recent phpunit versions (since 7.2.0) :

> `- Element 'element': The attribute 'key' is required but missing.`

This requirement is far from being new, what is recent is phpunit
validating its configuration file against the XSD schema.

See sebastianbergmann/phpunit@d4484be

This is pedantic (not a bugfix), and might be a bit painful to merge upstream, so if you feel like I should target a more recent instead and let the old branches go on with their lives, please tell me.

Commits
-------

c0733c2 Add required key attribute
  • Loading branch information
nicolas-grekas committed Nov 11, 2018
2 parents c887558 + c0733c2 commit 131a42b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
<array>
<element key="time-sensitive">
<array>
<element><string>Symfony\Component\Console</string></element>
<element><string>Symfony\Component\HttpFoundation</string></element>
<element key="0"><string>Symfony\Component\Console</string></element>
<element key="1"><string>Symfony\Component\HttpFoundation</string></element>
</array>
</element>
</array>
Expand Down

0 comments on commit 131a42b

Please sign in to comment.