Skip to content

Commit

Permalink
Change example of tagTemplate in config-network to the same value of …
Browse files Browse the repository at this point in the history
…default (knative#6186)

As knative#6178 reported, the
default value of tagTemplate is:

https://github.com/knative/serving/blob/b8a17ae4bac00a9749ba65b822db697cd582df50/pkg/network/network.go#L119

which is opposite from the example in `config-network`. As discussed
in knative#3492, the example value
should be defaults to avoid confusion.
  • Loading branch information
nak3 authored and knative-prow-robot committed Dec 10, 2019
1 parent cc2e951 commit 0964960
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/config-network.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ data:
# when constructing the DNS name for "tags" within the traffic blocks
# of Routes and Configuration. This is used in conjunction with the
# domainTemplate above to determine the full URL for the tag.
tagTemplate: "{{.Name}}-{{.Tag}}"
tagTemplate: "{{.Tag}}-{{.Name}}"
# Controls whether TLS certificates are automatically provisioned and
# installed in the Knative ingress to terminate external TLS connection.
Expand Down

0 comments on commit 0964960

Please sign in to comment.