Fix allocation when the amount is smaller than the number of ratios

stfalcon-studio · Feb 16, 2018 · 4ce781b · 4ce781b
1 parent 1fe4454
commit 4ce781b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fixed
+
+- Allocation when the amount is smaller than the number of ratios
+
 
 ## [3.1.2] - 2018-02-16
 

diff --git a/src/Money.php b/src/Money.php
@@ -391,7 +391,7 @@ public function allocate(array $ratios)
         }
 
         for ($i = 0; $this->getCalculator()->compare($remainder, 0) === 1; ++$i) {
-            if (!$results[$i]->amount) {
+            if (!$ratios[$i]) {
                 continue;
             }
 

diff --git a/tests/MoneyTest.php b/tests/MoneyTest.php
@@ -302,6 +302,8 @@ public function allocationExamples()
             [5, [0, 0, 1], [0, 0, 5]],
             [5, [0, 3, 7], [0, 2, 3]],
             [0, [0, 0, 1], [0, 0, 0]],
+            [2, [1, 1, 1], [1, 1, 0]],
+            [1, [1, 1], [1, 0]],
         ];
     }