fix failing elm-analyse checks

stil4m · Oct 9, 2019 · 742b4f9 · 742b4f9
1 parent 9a60486
commit 742b4f9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 15 deletions.
diff --git a/src/ASTUtil/Functions.elm b/src/ASTUtil/Functions.elm
@@ -15,11 +15,9 @@ isStatic function =
     if List.length decl.arguments > 0 then
         False
 
-    else if Maybe.withDefault False <| Maybe.map (Node.value >> isFunctionSignature) function.signature then
-        False
-
     else
-        True
+        Maybe.withDefault True <|
+            Maybe.map (Node.value >> isFunctionSignature >> not) function.signature
 
 
 isFunctionSignature : Signature -> Bool

diff --git a/src/Analyser/Checks/DebugCrash.elm b/src/Analyser/Checks/DebugCrash.elm
@@ -66,11 +66,7 @@ onExpression (Node range expression) context =
 entryForQualifiedExpr : List String -> String -> Bool
 entryForQualifiedExpr moduleName f =
     if moduleName == [ "Debug" ] then
-        if f == "todo" then
-            True
-
-        else
-            False
+        f == "todo"
 
     else
         False
diff --git a/src/Analyser/Checks/DebugLog.elm b/src/Analyser/Checks/DebugLog.elm
@@ -62,11 +62,7 @@ onExpression (Node range expression) context =
 entryForQualifiedExpr : List String -> String -> Bool
 entryForQualifiedExpr moduleName f =
     if moduleName == [ "Debug" ] then
-        if f == "log" then
-            True
-
-        else
-            False
+        f == "log"
 
     else
         False
diff --git a/src/Analyser/Checks/UnnecessaryLiteralBools.elm b/src/Analyser/Checks/UnnecessaryLiteralBools.elm
@@ -7,7 +7,7 @@ import Analyser.Configuration exposing (Configuration)
 import Analyser.FileContext exposing (FileContext)
 import Analyser.Messages.Data as Data exposing (MessageData)
 import Analyser.Messages.Schema as Schema
-import Elm.Syntax.Expression exposing (Case, Expression(..))
+import Elm.Syntax.Expression exposing (Expression(..))
 import Elm.Syntax.Node exposing (Node(..))
 import Elm.Syntax.Pattern exposing (Pattern(..))