Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Click to Minimise/Zoom & Fixes for Missing Traffic Light and Dark Menu Bar #83

Merged
merged 10 commits into from
Oct 4, 2015

Conversation

andersio
Copy link
Contributor

@andersio andersio commented Oct 2, 2015

This PR:

  1. Reintroduced the ability to Double Click In Titlebar to Zoom/Minimize*. (Application does not gets minimized. #54)
  2. Fixed an issue preventing the traffic light from showing up in a circumstance. (Window buttons are gone after fullscreen #66)
  3. Fixed the barely visible status item when using a dark menu bar. (Chit Chat Top Bar Icon Barely Visible in Dark Mode #80)
  4. Fixed a few lines with inconsistent code style that came with my previous commits. Sorry about that. :(

* courtesy: https://bugzilla.mozilla.org/show_bug.cgi?id=853105, though as a side note the plist key has been changed for 10.10 and later.

@andersio
Copy link
Contributor Author

andersio commented Oct 3, 2015

Merged #84.

@andersio andersio changed the title [Fix] Double Click in Title Bar to Minimise/Zoom & Missing Traffic Light Double Click to Minimise/Zoom & Fix for Missing Traffic Light & Fix for Dark Menu Bar Oct 3, 2015
@andersio andersio changed the title Double Click to Minimise/Zoom & Fix for Missing Traffic Light & Fix for Dark Menu Bar Double Click to Minimise/Zoom, Fix for Missing Traffic Light & Fix for Dark Menu Bar Oct 3, 2015
@andersio andersio changed the title Double Click to Minimise/Zoom, Fix for Missing Traffic Light & Fix for Dark Menu Bar Double Click to Minimise/Zoom & Fixes for Missing Traffic Light and Dark Menu Bar Oct 3, 2015
@stonesam92 stonesam92 merged commit 728419d into stonesam92:master Oct 4, 2015
@stonesam92
Copy link
Owner

Thanks once again, @andersio!

I had to change windowWillEnterFullScreen: to windowDidEnterFullScreen: in order to get the traffic light buttons to show in fullscreen mode on 10.10, but other than that everything appears to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants