Skip to content

Commit

Permalink
restore delivery_method after test
Browse files Browse the repository at this point in the history
Currently use two variables to restore `delivery_method`, but the order
of restoring the values is incorrect and does not restore is correctly.
  • Loading branch information
y-yagi committed Jan 28, 2017
1 parent c131758 commit a28f8b5
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions actionmailer/test/parameterized_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ class ParameterizedTest < ActiveSupport::TestCase
@previous_logger = ActiveJob::Base.logger
ActiveJob::Base.logger = Logger.new(nil)

@original_delivery_method = ActionMailer::Base.delivery_method
@previous_delivery_method = ActionMailer::Base.delivery_method
ActionMailer::Base.delivery_method = :test

@previous_delivery_method = ActionMailer::Base.delivery_method
@previous_deliver_later_queue_name = ActionMailer::Base.deliver_later_queue_name
ActionMailer::Base.deliver_later_queue_name = :test_queue
ActionMailer::Base.delivery_method = :test
Expand All @@ -24,8 +23,6 @@ class ParameterizedTest < ActiveSupport::TestCase
ActiveJob::Base.logger = @previous_logger
ParamsMailer.deliveries.clear

ActionMailer::Base.delivery_method = @original_delivery_method

ActionMailer::Base.delivery_method = @previous_delivery_method
ActionMailer::Base.deliver_later_queue_name = @previous_deliver_later_queue_name
end
Expand Down

0 comments on commit a28f8b5

Please sign in to comment.