Skip to content

Commit

Permalink
ALSA: firewire-lib: code refactoring for local variables
Browse files Browse the repository at this point in the history
It's better to use int type for loop index. For consistency, the name
of local variable for the number of data block should be plural.

Signed-off-by: Takashi Sakamoto <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
takaswie authored and tiwai committed Jul 8, 2019
1 parent 02394af commit 0dcb4ef
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions sound/firewire/amdtp-stream.c
Original file line number Diff line number Diff line change
Expand Up @@ -700,15 +700,16 @@ static void out_stream_callback(struct fw_iso_context *context, u32 tstamp,
{
struct amdtp_stream *s = private_data;
const __be32 *ctx_header = header;
unsigned int i, packets = header_length / sizeof(*ctx_header);
unsigned int packets = header_length / sizeof(*ctx_header);
int i;

if (s->packet_index < 0)
return;

for (i = 0; i < packets; ++i) {
u32 cycle;
unsigned int syt;
unsigned int data_block;
unsigned int data_blocks;
__be32 *buffer;
unsigned int pcm_frames;
struct {
Expand All @@ -719,12 +720,13 @@ static void out_stream_callback(struct fw_iso_context *context, u32 tstamp,

cycle = compute_it_cycle(*ctx_header);
syt = calculate_syt(s, cycle);
data_block = calculate_data_blocks(s, syt);
data_blocks = calculate_data_blocks(s, syt);
buffer = s->buffer.packets[s->packet_index].buffer;
pcm_frames = s->process_data_blocks(s, buffer, data_block, &syt);
pcm_frames = s->process_data_blocks(s, buffer, data_blocks,
&syt);

build_it_pkt_header(s, cycle, &template.params, data_block, syt,
i);
build_it_pkt_header(s, cycle, &template.params, data_blocks,
syt, i);

if (queue_out_packet(s, &template.params) < 0) {
cancel_stream(s);
Expand Down

0 comments on commit 0dcb4ef

Please sign in to comment.