Skip to content

Commit

Permalink
ALSA: firewire-lib/fireface: fix initial value of data block counter …
Browse files Browse the repository at this point in the history
…for IR context with CIP_NO_HEADER

For IR context, ALSA IEC 61883-1/6 engine uses initial value of data
block counter as UINT_MAX, to detect first isochronous packet in the
middle of packet streaming.

At present, when CIP_NO_HEADER is used (i.e. for ALSA fireface driver),
the initial value is used for tracepoints event. 0x00 should be
for the event when the initial value is UINT_MAX because isochronous
packets with CIP_NO_HEADER option has no field for data block count.

This commit fixes the bug.

Fixes: 7686486 ("ALSA: firewire-lib: cache next data_block_counter after probing tracepoints event for IR context")
Signed-off-by: Takashi Sakamoto <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
takaswie authored and tiwai committed Jul 8, 2019
1 parent 0ebf3ce commit 7fbf909
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion sound/firewire/amdtp-stream.c
Original file line number Diff line number Diff line change
Expand Up @@ -646,8 +646,12 @@ static int parse_ir_ctx_header(struct amdtp_stream *s, unsigned int cycle,
err = 0;
*data_blocks = *payload_length / sizeof(__be32) /
s->data_block_quadlets;
*dbc = s->data_block_counter;
*syt = 0;

if (s->data_block_counter != UINT_MAX)
*dbc = s->data_block_counter;
else
*dbc = 0;
}

if (err >= 0 && s->flags & CIP_DBC_IS_END_EVENT)
Expand Down

0 comments on commit 7fbf909

Please sign in to comment.