lib/digsig: checks for NULL return value

mpi_read_from_buffer() return value must not be NULL. Signed-off-by: Dmitry Kasatkin <[email protected]> Reviewed-by: Tetsuo Handa <[email protected]> Signed-off-by: James Morris <[email protected]>
strager · Feb 1, 2012 · 86f8bed · 86f8bed
1 parent 43b2c0a
commit 86f8bed
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/digsig.c b/lib/digsig.c
@@ -109,9 +109,13 @@ static int digsig_verify_rsa(struct key *key,
 	datap = pkh->mpi;
 	endp = ukp->data + ukp->datalen;
 
+	err = -ENOMEM;
+
 	for (i = 0; i < pkh->nmpi; i++) {
 		unsigned int remaining = endp - datap;
 		pkey[i] = mpi_read_from_buffer(datap, &remaining);
+		if (!pkey[i])
+			goto err;
 		datap += remaining;
 	}
 
@@ -168,8 +172,8 @@ static int digsig_verify_rsa(struct key *key,
 	mpi_free(res);
 	kfree(out1);
 	kfree(out2);
-	mpi_free(pkey[0]);
-	mpi_free(pkey[1]);
+	while (--i >= 0)
+		mpi_free(pkey[i]);
 err1:
 	up_read(&key->sem);