Skip to content

Commit

Permalink
enetc: Add missing call to 'pci_free_irq_vectors()' in probe and remo…
Browse files Browse the repository at this point in the history
…ve functions

Call to 'pci_free_irq_vectors()' are missing both in the error handling
path of the probe function, and in the remove function.
Add them.

Fixes: 19971f5 ("enetc: add PTP clock driver")
Signed-off-by: Christophe JAILLET <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
tititiou36 authored and davem330 committed Sep 1, 2019
1 parent dd1bf47 commit dd7078f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/net/ethernet/freescale/enetc/enetc_ptp.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ static int enetc_ptp_probe(struct pci_dev *pdev,
n = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_MSIX);
if (n != 1) {
err = -EPERM;
goto err_irq;
goto err_irq_vectors;
}

ptp_qoriq->irq = pci_irq_vector(pdev, 0);
Expand All @@ -107,6 +107,8 @@ static int enetc_ptp_probe(struct pci_dev *pdev,
err_no_clock:
free_irq(ptp_qoriq->irq, ptp_qoriq);
err_irq:
pci_free_irq_vectors(pdev);
err_irq_vectors:
iounmap(base);
err_ioremap:
kfree(ptp_qoriq);
Expand All @@ -125,6 +127,7 @@ static void enetc_ptp_remove(struct pci_dev *pdev)

enetc_phc_index = -1;
ptp_qoriq_free(ptp_qoriq);
pci_free_irq_vectors(pdev);
kfree(ptp_qoriq);

pci_release_mem_regions(pdev);
Expand Down

0 comments on commit dd7078f

Please sign in to comment.