ItBit: Remove exchange implementation (thrasher-corp#1463)

README.md

@@ -36,7 +36,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Gemini | Yes | Yes | No |
 | HitBTC | Yes | Yes | No |
 | Huobi.Pro | Yes | Yes | NA |
-| ItBit | Yes | NA | No |
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | NA |
 | Lbank | Yes | No | NA |

cmd/apichecker/apicheck.go

@@ -38,7 +38,6 @@ const (
 	pathBitmex           = "https://www.bitmex.com/static/md/en-US/apiChangelog"
 	pathANX              = "https://anxv3.docs.apiary.io/"
 	pathPoloniex         = "https://docs.poloniex.com/#changelog"
-	pathIbBit            = "https://api.itbit.com/docs"
 	pathBTCMarkets       = "https://api.btcmarkets.net/openapi/info/index.yaml"
 	pathEXMO             = "https://exmo.com/en/api/"
 	pathBitstamp         = "https://www.bitstamp.net/api/"
@@ -468,8 +467,6 @@ func checkChangeLog(htmlData *HTMLScrapingData) (string, error) {
 		dataStrings, err = htmlScrapeANX(htmlData)
 	case pathPoloniex:
 		dataStrings, err = htmlScrapePoloniex(htmlData)
-	case pathIbBit:
-		dataStrings, err = htmlScrapeItBit(htmlData)
 	case pathBTCMarkets:
 		dataStrings, err = htmlScrapeBTCMarkets(htmlData)
 	case pathEXMO:
@@ -963,41 +960,6 @@ loop:
 	return resp, nil
 }
 
-// htmlScrapeItBit gets the check string for ItBit Exchange
-func htmlScrapeItBit(htmlData *HTMLScrapingData) ([]string, error) {
-	var resp []string
-	temp, err := sendHTTPGetRequest(htmlData.Path, nil)
-	if err != nil {
-		return nil, err
-	}
-	defer temp.Body.Close()
-	tokenizer := html.NewTokenizer(temp.Body)
-loop:
-	for {
-		next := tokenizer.Next()
-		switch next {
-		case html.ErrorToken:
-			break loop
-		case html.StartTagToken:
-			token := tokenizer.Token()
-			if token.Data == htmlData.TokenData {
-				for _, z := range token.Attr {
-					if z.Key == htmlData.Key {
-						r, err := regexp.Compile(htmlData.RegExp)
-						if err != nil {
-							return resp, err
-						}
-						if r.MatchString(z.Val) {
-							resp = append(resp, z.Val)
-						}
-					}
-				}
-			}
-		}
-	}
-	return resp, nil
-}
-
 // htmlScrapeBitstamp gets the check string for Bitstamp Exchange
 func htmlScrapeBitstamp(htmlData *HTMLScrapingData) ([]string, error) {
 	temp, err := sendHTTPGetRequest(htmlData.Path, nil)

cmd/apichecker/apicheck_test.go

@@ -317,21 +317,6 @@ func TestHTMLPoloniex(t *testing.T) {
 	}
 }
 
-func TestHTMLItBit(t *testing.T) {
-	t.Parallel()
-	data := HTMLScrapingData{TokenData: "a",
-		Key:           "href",
-		Val:           "changelog",
-		TokenDataEnd:  "div",
-		TextTokenData: "h2",
-		DateFormat:    "2006-01-02",
-		RegExp:        `^https://api.itbit.com/v\d{1}/$`,
-		Path:          "https://api.itbit.com/docs"}
-	if _, err := htmlScrapeItBit(&data); err != nil {
-		t.Error(err)
-	}
-}
-
 func TestHTMLScrapeExmo(t *testing.T) {
 	t.Parallel()
 	data := HTMLScrapingData{RegExp: `Last updated on [\s\S]*, 20\d{2}`,

cmd/apichecker/testupdates.json

@@ -169,20 +169,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "ItBit",
-   "CheckType": "HTML String Check",
-   "Data": {
-    "HTMLData": {
-     "TokenData": "a",
-     "Key": "href",
-     "RegExp": "^https://api.itbit.com/v\\d{1}/$",
-     "CheckString": "https://api.itbit.com/v1/",
-     "Path": "https://api.itbit.com/docs"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Bitmex",
    "CheckType": "HTML String Check",

cmd/apichecker/updates.json

@@ -169,20 +169,6 @@
    },
    "Disabled": false
   },
-  {
-   "Name": "ItBit",
-   "CheckType": "HTML String Check",
-   "Data": {
-    "HTMLData": {
-     "TokenData": "a",
-     "Key": "href",
-     "RegExp": "^https://api.itbit.com/v\\d{1}/$",
-     "CheckString": "https://api.itbit.com/v1/",
-     "Path": "https://api.itbit.com/docs"
-    }
-   },
-   "Disabled": false
-  },
   {
    "Name": "Bitmex",
    "CheckType": "HTML String Check",

cmd/documentation/exchanges_templates/exchanges_trade_readme.tmpl

@@ -59,7 +59,6 @@ _b in this context is an `IBotExchange` implemented struct_
 | Gemini | Yes | Yes | Yes |
 | HitBTC | Yes | Yes | Yes |
 | Huobi.Pro | Yes | Yes | No |
-| ItBit | Yes | NA | No |
 | Kraken | Yes | Yes | No |
 | Kucoin | Yes | No | Yes |
 | Lbank | Yes | No | Yes |

cmd/documentation/root_templates/root_readme.tmpl

@@ -37,7 +37,6 @@ Join our slack to discuss all things related to GoCryptoTrader! [GoCryptoTrader
 | Gemini | Yes | Yes | No |
 | HitBTC | Yes | Yes | No |
 | Huobi.Pro | Yes | Yes | NA |
-| ItBit | Yes | NA | No |
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | NA |
 | Lbank | Yes | No | NA |

cmd/exchange_wrapper_coverage/main.go

@@ -34,10 +34,6 @@ func main() {
 	var wg sync.WaitGroup
 	for i := range exchange.Exchanges {
 		name := exchange.Exchanges[i]
-		if name == "ftx" {
-			log.Println("Skipping exchange FTX...")
-			continue
-		}
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

cmd/exchange_wrapper_standards/exchange_wrapper_standards_test.go

@@ -602,7 +602,6 @@ var unsupportedExchangeNames = []string{
 	"testexch",
 	"alphapoint",
 	"bitflyer", // Bitflyer has many "ErrNotYetImplemented, which is true, but not what we care to test for here
-	"itbit",    // itbit has no way of retrieving pair data
 	"btse",     // 	TODO rm once timeout issues resolved
 	"poloniex", // 	outdated API // TODO rm once updated
 }

config_example.json

@@ -1919,81 +1919,6 @@
     }
    ]
   },
-  {
-   "name": "ITBIT",
-   "enabled": true,
-   "verbose": false,
-   "httpTimeout": 15000000000,
-   "websocketResponseCheckTimeout": 30000000,
-   "websocketResponseMaxLimit": 7000000000,
-   "websocketTrafficTimeout": 30000000000,
-   "websocketOrderbookBufferLimit": 5,
-   "baseCurrencies": "USD,SGD",
-   "currencyPairs": {
-    "requestFormat": {
-     "uppercase": true
-    },
-    "configFormat": {
-     "uppercase": true
-    },
-    "useGlobalFormat": true,
-    "lastUpdated": 1591062026,
-    "assetTypes": [
-     "spot"
-    ],
-    "pairs": {
-     "spot": {
-      "enabled": "XBTUSD,XBTSGD",
-      "available": "XBTUSD,XBTSGD"
-     }
-    }
-   },
-   "api": {
-    "authenticatedSupport": false,
-    "authenticatedWebsocketApiSupport": false,
-    "endpoints": {
-     "url": "NON_DEFAULT_HTTP_LINK_TO_EXCHANGE_API",
-     "urlSecondary": "NON_DEFAULT_HTTP_LINK_TO_EXCHANGE_API",
-     "websocketURL": "NON_DEFAULT_HTTP_LINK_TO_WEBSOCKET_EXCHANGE_API"
-    },
-    "credentials": {
-     "key": "Key",
-     "secret": "Secret",
-     "clientID": "ClientID"
-    },
-    "credentialsValidator": {
-     "requiresSecret": true,
-     "requiresClientID": true
-    }
-   },
-   "features": {
-    "supports": {
-     "restAPI": true,
-     "restCapabilities": {},
-     "websocketAPI": false,
-     "websocketCapabilities": {}
-    },
-    "enabled": {
-     "autoPairUpdates": false,
-     "websocketAPI": false
-    }
-   },
-   "bankAccounts": [
-    {
-     "enabled": false,
-     "bankName": "",
-     "bankAddress": "",
-     "bankPostalCode": "",
-     "bankPostalCity": "",
-     "bankCountry": "",
-     "accountName": "",
-     "accountNumber": "",
-     "swiftCode": "",
-     "iban": "",
-     "supportedCurrencies": ""
-    }
-   ]
-  },
   {
    "name": "Kraken",
    "enabled": true,

docs/ADD_NEW_EXCHANGE.md

@@ -213,7 +213,6 @@ Yes means supported, No means not yet implemented and NA means protocol unsuppor
 | Gemini | Yes | Yes | No |
 | HitBTC | Yes | Yes | No |
 | Huobi.Pro | Yes | Yes | NA |
-| ItBit | Yes | NA | No |
 | Kraken | Yes | Yes | NA |
 | Kucoin | Yes | Yes | No |
 | Lbank | Yes | No | NA |
@@ -243,7 +242,6 @@ var Exchanges = []string{
 	"gemini",
 	"hitbtc",
 	"huobi",
-	"itbit",
 	"kraken",
 	"kucoin",
 	"lbank",

docs/MULTICHAIN_TRANSFER_SUPPORT.md

@@ -60,7 +60,6 @@ $ ./gctcli withdrawcryptofunds --exchange=binance --currency=USDT --address=TJU9
 | Gemini | No | No | |
 | HitBTC | No | No | |
 | Huobi.Pro | Yes | Yes | |
-| ItBit | No | No | |
 | Kraken | Yes | Yes | Front-end and API don't match total available transfer chains |
 | Kucoin |  Yes | Yes | |
 | Lbank | No | No | |

docs/OHLCV.md

@@ -81,8 +81,7 @@ A helper tool [cmd/dbseed](../cmd/dbseed/README.md) has been created for assisti
 | GateIO         | Y           |
 | Gemini         |             |
 | HitBTC         | Y           |     
-| Huobi          | Y           |      
-| itBIT          |             |          
+| Huobi          | Y           |              
 | Kraken         | Y           |
 | Kucoin         | Y           |                 
 | lBank          | Y           |                

engine/engine_test.go

@@ -355,7 +355,6 @@ func TestSettingsPrint(t *testing.T) {
 }
 
 var unsupportedDefaultConfigExchanges = []string{
-	"itbit",    // due to unsupported API
 	"poloniex", // poloniex has dropped support for the API GCT has implemented //TODO: drop this when supported
 }