Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopologicalRouteSearch with start and goal as the same node #355

Open
gpdas opened this issue Jun 19, 2018 · 3 comments
Open

TopologicalRouteSearch with start and goal as the same node #355

gpdas opened this issue Jun 19, 2018 · 3 comments

Comments

@gpdas
Copy link
Contributor

gpdas commented Jun 19, 2018

TopologicalRouteSearch in strands_navigation/topological_navigation/src/topological_navigation/route_search.py

If we search route from a node A to the same node using search_route method of this class, it will return a loop A -> B -> A (assuming bi-directional edges exist between A and another node B).

@marc-hanheide
Copy link
Member

Really?? @Jailander ? I don't think this used to be the case.

@Jailander
Copy link
Member

No I am sure it wasn't like that, will check as soon as I can

@gpdas
Copy link
Contributor Author

gpdas commented Jul 25, 2019

A fix is in #376. Returns None if origin and target are the same.
This was not a problem in topological_navigation or execute_policy_mode as the nodes are checked in navigate.py before routes are searched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants