Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable edge_reconfig for execute_policy_mode server #376

Merged

Conversation

gpdas
Copy link
Contributor

@gpdas gpdas commented Jul 24, 2019

  1. edge reconfig ported from topological_navigation/navigation.py (Move base parameters being reconfigured at edges #374 )

When this mode is enabled via the /topological_navigation/execute_policy_mode/reconfigure_edges parameter, execute_navigation_mode action server will change edge action parameters (e.g. move_base/DWAPlannerROS) according to the /edge_nav_reconfig_groups parameter's values and edges being navigated, an example of this configuration is as follows:

edge_nav_reconfig_groups:
  irn:
    edges:
      - WayPoint1_WayPoint2
      - WayPoint2_WayPoint3
      - WayPoint3_WayPoint4
    parameters:
      - &id001
        name: forward_point_distance
        ns: move_base/DWAPlannerROS
        type: double
        value: 0.48297542551971
  orn:
    edges:
      - WayPoint66_WayPoint57
      - WayPoint57_WayPoint66
    parameters:
      - *id001
  utn:
    edges:
      - WayPoint46_WayPoint47
    parameters:
      - name: forward_point_distance
        ns: move_base/DWAPlannerROS
        type: double
        value: 0.1402690117118645
  1. minor fixes in
  • topological_navigation/navigation.py
  • topological_navigation/route_search.py

gpdas added 2 commits July 24, 2019 16:49
1. edge reconfig ported from topological_navigation/navigation.py
2. minor fixes in
  - topological_navigation/navigation.py
  - topological_navigation/route_search.py
@gpdas gpdas closed this Jul 25, 2019
@gpdas gpdas reopened this Jul 25, 2019
@gpdas
Copy link
Contributor Author

gpdas commented Jul 25, 2019

Commit ac4c403 fixes #355

@gpdas
Copy link
Contributor Author

gpdas commented Jul 25, 2019

18:59:42 Traceback (most recent call last):
18:59:42   File "/tmp/ros_buildfarm/scripts/devel/create_devel_task_generator.py", line 235, in resolve_names
18:59:42     rosdep_key, view, installer, os_name, os_code_name)
18:59:42   File "/usr/lib/python3/dist-packages/rosdep2/catkin_support.py", line 87, in resolve_for_os
18:59:42     d = view.lookup(rosdep_key)
18:59:42   File "/usr/lib/python3/dist-packages/rosdep2/lookup.py", line 197, in lookup
18:59:42     return self.rosdep_defs[rosdep_name]
18:59:42 KeyError: 'message_store_map_switcher'

@gpdas
Copy link
Contributor Author

gpdas commented Jul 29, 2019

@Jailander can you have a look at this please?

@Jailander
Copy link
Member

Hi, I am happy with these, I tested them briefly didn't seem to break anything, but @bfalacerda maybe you want to double check this one before I merge?

@bfalacerda
Copy link
Contributor

i can give it a quick test tmrw afternoon

@Jailander
Copy link
Member

thanks!!!

@bfalacerda
Copy link
Contributor

I didn't test the functionalities introduced by this PR but it doesn't break our setup, so happy for it to be merged

@Jailander
Copy link
Member

:) thanks !! Will merge

@Jailander Jailander merged commit c1d3b34 into strands-project:indigo-devel Aug 2, 2019
@gpdas gpdas deleted the exec_policy_reconf_edge branch August 2, 2019 08:48
@gpdas
Copy link
Contributor Author

gpdas commented Aug 2, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants