Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unix specific execution permission to tp binary executable #1293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add unix specific execution permission to tp binary executable #1293

wants to merge 2 commits into from
+17 −1

Conversation

Shourya742
Copy link
Contributor

closes #1278

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.30%. Comparing base (22da418) to head (971ee7b).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1293   +/-   ##
=======================================
  Coverage   19.30%   19.30%           
=======================================
  Files         164      164           
  Lines       10849    10849           
=======================================
  Hits         2094     2094           
  Misses       8755     8755
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.55% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 marked this pull request as draft December 12, 2024 06:34
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-template-provider-binary-permission
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,645.90
(+0.05%)		7,100.65
(93.60%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,429.30
(-1.20%)		8,108.13
(91.63%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,051.00
(-0.80%)		8,599.09
(93.63%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		866.07
(+0.05%)		925.94
(93.53%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		680.71
(+1.13%)		710.58
(95.80%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		261.03
(+4.81%)		273.45
(95.46%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		166.00
(+5.40%)		168.86
(98.31%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,396.10
(-0.60%)		7,078.87
(90.35%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		287.29
(+2.47%)		304.61
(94.31%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		737.07
(+1.16%)		780.19
(94.47%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		602.92
(+2.04%)		634.73
(94.99%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		205.08
(-0.36%)		217.41
(94.33%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-template-provider-binary-permission
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,455.00
(-0.04%)		8,725.56
(96.90%)		📈 view plot
🚷 view threshold		3,689.00
(-1.38%)		3,869.06
(95.35%)		📈 view plot
🚷 view threshold		5,155.00
(-1.66%)		5,450.48
(94.58%)		📈 view plot
🚷 view threshold		9.00
(+19.25%)		14.62
(61.54%)		📈 view plot
🚷 view threshold		93.00
(+2.39%)		95.77
(97.11%)
get_submit📈 view plot
🚷 view threshold		95,239.00
(-0.17%)		95,848.13
(99.36%)		📈 view plot
🚷 view threshold		59,346.00
(-0.16%)		59,712.28
(99.39%)		📈 view plot
🚷 view threshold		85,219.00
(-0.18%)		85,815.98
(99.30%)		📈 view plot
🚷 view threshold		51.00
(+15.13%)		60.18
(84.74%)		📈 view plot
🚷 view threshold		279.00
(-0.43%)		290.11
(96.17%)
get_subscribe📈 view plot
🚷 view threshold		7,940.00
(-0.90%)		8,280.98
(95.88%)		📈 view plot
🚷 view threshold		2,765.00
(-2.18%)		2,949.59
(93.74%)		📈 view plot
🚷 view threshold		3,845.00
(-2.61%)		4,144.95
(92.76%)		📈 view plot
🚷 view threshold		14.00
(+18.05%)		19.98
(70.07%)		📈 view plot
🚷 view threshold		115.00
(+0.51%)		118.59
(96.97%)
serialize_authorize📈 view plot
🚷 view threshold		12,184.00
(-0.73%)		12,565.09
(96.97%)		📈 view plot
🚷 view threshold		5,266.00
(-0.88%)		5,435.12
(96.89%)		📈 view plot
🚷 view threshold		7,324.00
(-1.10%)		7,606.70
(96.28%)		📈 view plot
🚷 view threshold		13.00
(+37.98%)		17.58
(73.95%)		📈 view plot
🚷 view threshold		137.00
(-0.55%)		142.58
(96.08%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,674.00
(-0.13%)		25,205.78
(97.89%)		📈 view plot
🚷 view threshold		9,838.00
(-0.42%)		10,037.49
(98.01%)		📈 view plot
🚷 view threshold		13,874.00
(-0.51%)		14,201.51
(97.69%)		📈 view plot
🚷 view threshold		39.00
(+11.58%)		44.95
(86.77%)		📈 view plot
🚷 view threshold		303.00
(+0.19%)		314.22
(96.43%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,190.00
(-0.45%)		30,750.35
(98.18%)		📈 view plot
🚷 view threshold		12,015.00
(-0.46%)		12,207.98
(98.42%)		📈 view plot
🚷 view threshold		16,995.00
(-0.56%)		17,311.84
(98.17%)		📈 view plot
🚷 view threshold		63.00
(+13.32%)		67.48
(93.37%)		📈 view plot
🚷 view threshold		368.00
(-0.60%)		380.75
(96.65%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,257.00
(-0.17%)		126,908.19
(99.49%)		📈 view plot
🚷 view threshold		73,200.00
(-0.10%)		73,534.05
(99.55%)		📈 view plot
🚷 view threshold		104,912.00
(-0.13%)		105,486.58
(99.46%)		📈 view plot
🚷 view threshold		111.00
(+4.79%)		125.93
(88.14%)		📈 view plot
🚷 view threshold		594.00
(-0.49%)		607.19
(97.83%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,790.00
(-0.30%)		28,535.40
(97.39%)		📈 view plot
🚷 view threshold		9,584.00
(-0.61%)		9,763.82
(98.16%)		📈 view plot
🚷 view threshold		13,530.00
(-0.78%)		13,832.50
(97.81%)		📈 view plot
🚷 view threshold		73.00
(+14.79%)		76.20
(95.80%)		📈 view plot
🚷 view threshold		397.00
(-0.18%)		414.39
(95.80%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,161.00
(-0.08%)		115,780.89
(99.46%)		📈 view plot
🚷 view threshold		68,060.00
(-0.05%)		68,414.98
(99.48%)		📈 view plot
🚷 view threshold		97,646.00
(-0.07%)		98,266.84
(99.37%)		📈 view plot
🚷 view threshold		73.00
(+15.57%)		81.41
(89.67%)		📈 view plot
🚷 view threshold		490.00
(-0.42%)		500.74
(97.86%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,218.00
(-0.32%)		23,923.61
(97.05%)		📈 view plot
🚷 view threshold		8,143.00
(-0.67%)		8,319.73
(97.88%)		📈 view plot
🚷 view threshold		11,448.00
(-0.84%)		11,739.54
(97.52%)		📈 view plot
🚷 view threshold		44.00
(+16.92%)		46.87
(93.87%)		📈 view plot
🚷 view threshold		330.00
(-0.09%)		345.56
(95.50%)
serialize_submit📈 view plot
🚷 view threshold		99,628.00
(-0.20%)		100,283.37
(99.35%)		📈 view plot
🚷 view threshold		61,408.00
(-0.13%)		61,741.12
(99.46%)		📈 view plot
🚷 view threshold		88,078.00
(-0.16%)		88,646.03
(99.36%)		📈 view plot
🚷 view threshold		56.00
(+19.89%)		64.17
(87.27%)		📈 view plot
🚷 view threshold		322.00
(-0.90%)		335.43
(96.00%)
serialize_subscribe📈 view plot
🚷 view threshold		11,385.00
(-0.18%)		11,674.53
(97.52%)		📈 view plot
🚷 view threshold		4,118.00
(-1.36%)		4,291.43
(95.96%)		📈 view plot
🚷 view threshold		5,705.00
(-1.73%)		5,997.63
(95.12%)		📈 view plot
🚷 view threshold		16.00
(+23.08%)		21.66
(73.87%)		📈 view plot
🚷 view threshold		160.00
(+1.17%)		163.78
(97.69%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-template-provider-binary-permission
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.26
(-0.61%)		46.70
(94.79%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		74.59
(-2.27%)		93.72
(79.59%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(+0.01%)		14.76
(99.32%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		269.45
(+1.20%)		298.46
(90.28%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		615.34
(-0.16%)		671.03
(91.70%)
client_sv2_open_channel📈 view plot
🚷 view threshold		167.92
(+4.08%)		190.59
(88.10%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		288.74
(+1.51%)		310.89
(92.88%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		377.98
(-1.47%)		411.81
(91.79%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		159.50
(-0.54%)		171.14
(93.20%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		510.79
(+8.21%)		555.87
(91.89%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		981.52
(-1.34%)		1,076.94
(91.14%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-12-fix-template-provider-binary-permission
Testbedsv2

🚨 1 Alert

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert (🔔)
🚷 threshold		95.00
(+15.62%)		94.11
(100.95%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,057.00
(-2.14%)		2,215.54
(92.84%)		📈 view plot
🚷 view threshold		473.00
(-0.08%)		488.79
(96.77%)		📈 view plot
🚷 view threshold		737.00
(+0.15%)		757.52
(97.29%)		📈 view plot
🚷 view threshold		5.00
(-2.88%)		13.15
(38.03%)		📈 view plot
🚷 view threshold		37.00
(-3.39%)		41.36
(89.46%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,348.00
(+1.65%)		8,350.03
(99.98%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,153.00
(-0.23%)		3,171.20
(99.43%)		📈 view plot
🚷 view threshold		38.00
(+7.42%)		41.36
(91.88%)		📈 view plot
🚷 view threshold		143.00
(+2.66%)		143.09
(99.94%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,319.00
(+0.44%)		6,425.22
(98.35%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,767.12
(99.03%)		📈 view plot
🚷 view threshold		2,549.00
(-0.16%)		2,575.82
(98.96%)		📈 view plot
🚷 view threshold		19.00
(+11.87%)		24.28
(78.26%)		📈 view plot
🚷 view threshold		105.00
(+0.60%)		108.10
(97.14%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,786.00
(+0.41%)		14,941.79
(98.96%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.12
(99.64%)		📈 view plot
🚷 view threshold		6,746.00
(-0.18%)		6,784.33
(99.44%)		📈 view plot
🚷 view threshold		54.00
(+22.51%)		57.10
(94.56%)		📈 view plot
🚷 view threshold		222.00
(+0.30%)		226.87
(97.85%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,770.00
(+0.77%)		27,921.82
(99.46%)		📈 view plot
🚷 view threshold		10,645.00
(+0.48%)		10,673.65
(99.73%)		📈 view plot
🚷 view threshold		15,500.00
(+0.53%)		15,550.78
(99.67%)		📈 view plot
🚨 view alert (🔔)
🚷 view threshold		95.00
(+15.62%)		94.11
(100.95%)		📈 view plot
🚷 view threshold		337.00
(+0.56%)		341.81
(98.59%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,443.00
(+1.26%)		4,558.57
(97.46%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,476.79
(98.93%)		📈 view plot
🚷 view threshold		2,158.00
(-0.12%)		2,183.52
(98.83%)		📈 view plot
🚷 view threshold		9.00
(+6.96%)		15.32
(58.75%)		📈 view plot
🚷 view threshold		64.00
(+2.52%)		67.19
(95.25%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,040.00
(+0.10%)		14,261.75
(98.45%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,079.79
(99.69%)		📈 view plot
🚷 view threshold		7,320.00
(-0.09%)		7,350.84
(99.58%)		📈 view plot
🚷 view threshold		42.00
(+18.73%)		44.93
(93.47%)		📈 view plot
🚷 view threshold		186.00
(-0.19%)		193.22
(96.26%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,786.00
(+0.51%)		22,943.44
(99.31%)		📈 view plot
🚷 view threshold		8,040.00
(+0.15%)		8,063.52
(99.71%)		📈 view plot
🚷 view threshold		11,691.00
(+0.10%)		11,731.33
(99.66%)		📈 view plot
🚷 view threshold		84.00
(+12.39%)		86.10
(97.56%)		📈 view plot
🚷 view threshold		305.00
(+0.54%)		310.38
(98.27%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,673.00
(-0.27%)		4,781.56
(97.73%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.79
(98.96%)		📈 view plot
🚷 view threshold		2,278.00
(-0.01%)		2,299.32
(99.07%)		📈 view plot
🚷 view threshold		10.00
(+3.64%)		16.50
(60.61%)		📈 view plot
🚷 view threshold		67.00
(-0.60%)		69.98
(95.75%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,176.00
(+0.14%)		16,364.42
(98.85%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,978.79
(99.74%)		📈 view plot
🚷 view threshold		8,656.00
(-0.10%)		8,690.80
(99.60%)		📈 view plot
🚷 view threshold		48.00
(+20.45%)		53.12
(90.37%)		📈 view plot
🚷 view threshold		208.00
(-0.14%)		213.73
(97.32%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,676.00
(+0.31%)		35,835.98
(99.55%)		📈 view plot
🚷 view threshold		14,888.00
(+0.19%)		14,911.25
(99.84%)		📈 view plot
🚷 view threshold		21,871.00
(+0.18%)		21,917.88
(99.79%)		📈 view plot
🚷 view threshold		108.00
(+16.95%)		112.40
(96.08%)		📈 view plot
🚷 view threshold		379.00
(-0.07%)		384.83
(98.49%)
🐰 View full continuous benchmarking report in Bencher

@Shourya742 Shourya742 force-pushed the 2024-12-12-fix-template-provider-binary-permission branch from 97140b4 to 971ee7b Compare December 12, 2024 06:48
@Shourya742 Shourya742 marked this pull request as ready for review December 12, 2024 07:01
@Shourya742 Shourya742 mentioned this pull request Dec 12, 2024
Open
@plebhash
Copy link
Collaborator

plebhash commented Dec 12, 2024 •
edited
Loading

@Shourya742 can you please edit the PR description with a detailed description of:

  • the root cause of the issue
  • the rationale behind this proposed solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test TemplateProvider OS E13
2 participants
@Shourya742 @plebhash