Fix set activity to private, thank you Fabio Moser

strava · Oct 3, 2014 · 12ed1cf · 12ed1cf
1 parent 0a1080f
commit 12ed1cf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/activities.go b/activities.go
@@ -249,7 +249,13 @@ func (c *ActivitiesPutCall) Type(activityType ActivityType) *ActivitiesPutCall {
 }
 
 func (c *ActivitiesPutCall) Private(isPrivate bool) *ActivitiesPutCall {
-	c.ops["private"] = isPrivate
+	// must be 0 or 1, or strava will set to public.
+	if isPrivate {
+		c.ops["private"] = 1
+	} else {
+		c.ops["private"] = 0
+	}
+
 	return c
 }
 

diff --git a/activities_test.go b/activities_test.go
@@ -346,7 +346,14 @@ func TestActivitiesUpdate(t *testing.T) {
 	// parameters3
 	s.Update(123).Private(false).Commute(true).Trainer(false).Do()
 
-	if transport.request.URL.RawQuery != "commute=true&private=false&trainer=false" {
+	if transport.request.URL.RawQuery != "commute=true&private=0&trainer=false" {
+		t.Errorf("request query incorrect, got %v", transport.request.URL.RawQuery)
+	}
+
+	// parameters4
+	s.Update(123).Private(true).Do()
+
+	if transport.request.URL.RawQuery != "private=1" {
 		t.Errorf("request query incorrect, got %v", transport.request.URL.RawQuery)
 	}
 }