-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metadata order in response when producing records #945
Conversation
Signed-off-by: Robert Young <[email protected]>
This uses the send CompletionStages to keep the original ordering of records. kafka-clients Producer#send only guarantees that callbacks are executed in order per partition, the ordering of partitions is not guaranteed. Signed-off-by: Robert Young <[email protected]>
the ppc64le build failed with:
doesn't sound related to produce changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good catch @robobario! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it works.
Signed-off-by: Paolo Patierno <[email protected]>
I am going to cherry-pick this one for the |
* Add integration test checking result ordering Signed-off-by: Robert Young <[email protected]> * fix: preserve record send order in response metadata This uses the send CompletionStages to keep the original ordering of records. kafka-clients Producer#send only guarantees that callbacks are executed in order per partition, the ordering of partitions is not guaranteed. Signed-off-by: Robert Young <[email protected]> * Updated CHANGELOG with metadata fix description Signed-off-by: Paolo Patierno <[email protected]> --------- Signed-off-by: Robert Young <[email protected]> Signed-off-by: Paolo Patierno <[email protected]> Co-authored-by: Paolo Patierno <[email protected]>
fix: preserve record send order in response metadata
This uses the send CompletionStages to keep the original ordering of records.
kafka-clients KafkaProducer#send only guarantees that callbacks are executed in order per partition, the ordering across partitions is not guaranteed.
Closes #944