Skip to content

Commit

Permalink
Fix TryToShrinkGlobalToBoolean in GlobalOpt, so that it does not disc…
Browse files Browse the repository at this point in the history
…ard address spaces.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@172051 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
jgouly committed Jan 10, 2013
1 parent 8a0f3f7 commit 1d505a3
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 12 deletions.
3 changes: 2 additions & 1 deletion lib/Transforms/IPO/GlobalOpt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1825,7 +1825,8 @@ static bool TryToShrinkGlobalToBoolean(GlobalVariable *GV, Constant *OtherVal) {
GlobalValue::InternalLinkage,
ConstantInt::getFalse(GV->getContext()),
GV->getName()+".b",
GV->getThreadLocalMode());
GV->getThreadLocalMode(),
GV->getType()->getAddressSpace());
GV->getParent()->getGlobalList().insert(GV, NewGV);

Constant *InitVal = GV->getInitializer();
Expand Down
27 changes: 16 additions & 11 deletions test/Transforms/GlobalOpt/integer-bool.ll
Original file line number Diff line number Diff line change
@@ -1,23 +1,28 @@
; RUN: opt < %s -globalopt -instcombine | \
; RUN: llvm-dis | grep "ret i1 true"

; RUN: opt < %s -S -globalopt -instcombine | FileCheck %s
;; check that global opt turns integers that only hold 0 or 1 into bools.

@G = internal global i32 0 ; <i32*> [#uses=3]
@G = internal addrspace(1) global i32 0
; CHECK @G.b
; CHECK addrspace(1)
; CHECK global i1 0

define void @set1() {
store i32 0, i32* @G
ret void
store i32 0, i32 addrspace(1)* @G
; CHECK: store i1 false
ret void
}

define void @set2() {
store i32 1, i32* @G
ret void
store i32 1, i32 addrspace(1)* @G
; CHECK: store i1 true
ret void
}

define i1 @get() {
%A = load i32* @G ; <i32> [#uses=1]
%C = icmp slt i32 %A, 2 ; <i1> [#uses=1]
ret i1 %C
; CHECK @get
%A = load i32 addrspace(1) * @G
%C = icmp slt i32 %A, 2
ret i1 %C
; CHECK: ret i1 true
}

0 comments on commit 1d505a3

Please sign in to comment.