Added unit tests for Cocoanetics#738

subashmvgr · Jul 4, 2014 · 6e10dbf · 6e10dbf
1 parent 4526ee7
commit 6e10dbf
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/Test/Source/DTHTMLAttributedStringBuilderTest.m b/Test/Source/DTHTMLAttributedStringBuilderTest.m
@@ -1116,6 +1116,15 @@ - (void)testDisplayStyleInheritance
 	XCTAssertTrue([lines count]==1, @"There should only be one line, display style block should not be inherited");
 }
 
+#pragma mark - Attachments
+
+// issue 738: Attachments with display:none should not show
+- (void)testAttachmentWithDisplayNone
+{
+	NSAttributedString *attributedString = [self attributedStringFromHTMLString:@"<img style=\"display:none;\" src=\"Oliver.jpg\">" options:nil];
+	XCTAssertEqual([attributedString length], 0, @"Text attachment should be invisible");
+}
+
 #pragma mark - Parsing Options
 
 // issue 649

diff --git a/Test/Source/DTHTMLElementTest.m b/Test/Source/DTHTMLElementTest.m
@@ -58,4 +58,25 @@ - (void)testCombiningWebKitAndNormalMargin
 	XCTAssertEqual(element.margins.bottom, 20, @"Incorrect bottom margin");
 }
 
+// issue 738: Attachments with display:none should not show
+- (void)testAttachmentWithDisplayNone
+{
+	DTHTMLElement *element = [[DTHTMLElement alloc] init];
+	element.textScale = 1;
+	element.paragraphStyle = [DTCoreTextParagraphStyle defaultParagraphStyle];
+	CTFontRef font = CTFontCreateWithName(CFSTR("Helvetica"), 20, NULL);
+	element.fontDescriptor = [DTCoreTextFontDescriptor fontDescriptorForCTFont:font];
+	CFRelease(font);
+
+	DTObjectTextAttachment *object = [[DTObjectTextAttachment alloc] initWithElement:element options:nil];
+	element.textAttachment = object;
+
+	NSDictionary *styles = @{@"display" : @"none"};
+	[element applyStyleDictionary:styles];
+
+	NSAttributedString *attributedString = [element attributedString];
+
+	XCTAssertNil(attributedString, @"Text attachment should be invisible");
+}
+
 @end