Skip to content

Commit

Permalink
Allow detach of an Android PlatformView that still holds a window (fl…
Browse files Browse the repository at this point in the history
…utter#2591)

The PlatformView may not receive the surfaceDestroy notification before its
activity is destroyed (this was happening on the Android emulator).

If this happens, allow the PlatformView to be detached and have it release
its window during destruction.
  • Loading branch information
jason-simmons committed Apr 11, 2016
1 parent 4265c10 commit c53ddc5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sky/shell/platform/android/platform_view_android.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ PlatformViewAndroid::~PlatformViewAndroid() {
}

void PlatformViewAndroid::Detach(JNIEnv* env, jobject obj) {
DCHECK(!window_);
shell_view_.reset();
// Note: |this| has been destroyed at this point.
}
Expand Down

0 comments on commit c53ddc5

Please sign in to comment.