Skip to content

Commit

Permalink
doc: macOS pre-merge validation should prefer Catalina (RobotLocomoti…
Browse files Browse the repository at this point in the history
…on#12695)

Testing on Catalina only is good enough, because Catalina and Mojave are
basically identical as far as what Drake uses.

Note that packaging builds still use (only) Mojave.
  • Loading branch information
jwnimmer-tri authored Feb 6, 2020
1 parent 5cc7d27 commit 5c3ab7f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
7 changes: 3 additions & 4 deletions doc/code_review_checklist.rst
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,11 @@ Did you change third-party software?

Changes to third-party software (e.g., upgrading to a newer version) are the
most common cause of CI divergence between Ubuntu and macOS. For PRs with such
changes, be sure to opt-in to the pre-merge macOS builds.
changes, be sure to opt-in to a pre-merge macOS build.

:ref:`Schedule an on-demand build <run_specific_build>` using one build from
each macOS revision currently available in CI. For example:
:ref:`Schedule one on-demand build <run_specific_build>` using an "everything"
flavor, for example:

* ``@drake-jenkins-bot mac-mojave-clang-bazel-experimental-release please``
* ``@drake-jenkins-bot mac-catalina-clang-bazel-experimental-everything-release please``

Have you run linting tools?
Expand Down
1 change: 0 additions & 1 deletion doc/jenkins.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ unprovisioned experimental builds, e.g.:

* ``@drake-jenkins-bot linux-bionic-unprovisioned-gcc-bazel-experimental-release please``
* ``@drake-jenkins-bot mac-catalina-unprovisioned-clang-bazel-experimental-release please``
* ``@drake-jenkins-bot mac-mojave-unprovisioned-clang-bazel-experimental-release please``

After this has passed, go through normal review. Once normal review is done,
add ``@jamiesnape`` for review and request that the provisioned instances be
Expand Down

0 comments on commit 5c3ab7f

Please sign in to comment.