Skip to content

Commit

Permalink
pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused …
Browse files Browse the repository at this point in the history
…and broken

Commit 6d33ee7 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in
'pxa2xx_pinctrl_init()'.
However, the corresponding 'pinctrl_unregister()' call in
'pxa2xx_pinctrl_exit()' has not been removed.

This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused.
Remove it now to avoid some wondering in the future and save a few LoC.

Fixes: 6d33ee7 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration")
Signed-off-by: Christophe JAILLET <[email protected]>
Acked-by: Robert Jarzmik <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Linus Walleij <[email protected]>
  • Loading branch information
tititiou36 authored and linusw committed Jun 3, 2020
1 parent ba40324 commit 08acc96
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions drivers/pinctrl/pxa/pinctrl-pxa2xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -425,15 +425,6 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev,
}
EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_init);

int pxa2xx_pinctrl_exit(struct platform_device *pdev)
{
struct pxa_pinctrl *pctl = platform_get_drvdata(pdev);

pinctrl_unregister(pctl->pctl_dev);
return 0;
}
EXPORT_SYMBOL_GPL(pxa2xx_pinctrl_exit);

MODULE_AUTHOR("Robert Jarzmik <[email protected]>");
MODULE_DESCRIPTION("Marvell PXA2xx pinctrl driver");
MODULE_LICENSE("GPL v2");

0 comments on commit 08acc96

Please sign in to comment.