Skip to content

Commit

Permalink
s390/numa: let NODES_SHIFT depend on NEED_MULTIPLE_NODES
Browse files Browse the repository at this point in the history
Qian Cai reported:
"""
When NUMA=n and nr_node_ids=2, in apply_wqattrs_prepare(), it has,

for_each_node(node) {
        if (wq_calc_node_cpumask(...

where it will trigger a booting warning,

WARNING: workqueue cpumask: online intersect > possible intersect

because it found 2 nodes and wq_numa_possible_cpumask[1] is an empty
cpumask.
"""

Let NODES_SHIFT depend on NEED_MULTIPLE_NODES like it is done
on other architectures in order to fix this.

Fixes: 701dc81 ("s390/mm: remove fake numa support")
Reported-by: Qian Cai <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
Signed-off-by: Vasily Gorbik <[email protected]>
  • Loading branch information
heicarst authored and Vasily Gorbik committed Jun 16, 2020
1 parent 478237a commit 64438e1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/s390/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ config NUMA

config NODES_SHIFT
int
depends on NEED_MULTIPLE_NODES
default "1"

config SCHED_SMT
Expand Down

0 comments on commit 64438e1

Please sign in to comment.