Skip to content

Commit

Permalink
scripts/kallsyms: make check_symbol_range() void function
Browse files Browse the repository at this point in the history
There is no more reason to check the return value of
check_symbol_range().

Signed-off-by: Masahiro Yamada <[email protected]>
  • Loading branch information
masahir0y committed Nov 25, 2019
1 parent 887df76 commit b6233d0
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions scripts/kallsyms.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ static bool is_ignored_symbol(const char *name, char type)
return false;
}

static int check_symbol_range(const char *sym, unsigned long long addr,
struct addr_range *ranges, int entries)
static void check_symbol_range(const char *sym, unsigned long long addr,
struct addr_range *ranges, int entries)
{
size_t i;
struct addr_range *ar;
Expand All @@ -166,14 +166,12 @@ static int check_symbol_range(const char *sym, unsigned long long addr,

if (strcmp(sym, ar->start_sym) == 0) {
ar->start = addr;
return 0;
return;
} else if (strcmp(sym, ar->end_sym) == 0) {
ar->end = addr;
return 0;
return;
}
}

return 1;
}

static int read_symbol(FILE *in, struct sym_entry *s)
Expand All @@ -200,9 +198,8 @@ static int read_symbol(FILE *in, struct sym_entry *s)
/* Ignore most absolute/undefined (?) symbols. */
if (strcmp(sym, "_text") == 0)
_text = s->addr;
else if (check_symbol_range(sym, s->addr, text_ranges,
ARRAY_SIZE(text_ranges)) == 0)
/* nothing to do */;

check_symbol_range(sym, s->addr, text_ranges, ARRAY_SIZE(text_ranges));

/* include the type field in the symbol name, so that it gets
* compressed together */
Expand Down

0 comments on commit b6233d0

Please sign in to comment.