Skip to content

Commit

Permalink
Not generate needless files in guides
Browse files Browse the repository at this point in the history
Not generate needless files:

* _license.html.erb, _welcome.html.erb are partial files.
* layout.html.erb is the layout file.
  • Loading branch information
yhirano55 committed Apr 2, 2018
1 parent 87d9228 commit f8d346f
Showing 1 changed file with 27 additions and 25 deletions.
52 changes: 27 additions & 25 deletions guides/rails_guides/generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -141,32 +141,34 @@ def generate_guide(guide, output_file)
puts "Generating #{guide} as #{output_file}"
layout = @kindle ? "kindle/layout" : "layout"

File.open(output_path, "w") do |f|
view = ActionView::Base.new(
@source_dir,
edge: @edge,
version: @version,
mobi: "kindle/#{mobi}",
language: @language
)
view.extend(Helpers)

if guide =~ /\.(\w+)\.erb$/
# Generate the special pages like the home.
# Passing a template handler in the template name is deprecated. So pass the file name without the extension.
result = view.render(layout: layout, formats: [$1], file: $`)
else
body = File.read("#{@source_dir}/#{guide}")
result = RailsGuides::Markdown.new(
view: view,
layout: layout,
edge: @edge,
version: @version
).render(body)

warn_about_broken_links(result)
end
view = ActionView::Base.new(
@source_dir,
edge: @edge,
version: @version,
mobi: "kindle/#{mobi}",
language: @language
)
view.extend(Helpers)

if guide =~ /\.(\w+)\.erb$/
return if %w[_license _welcome layout].include?($`)

# Generate the special pages like the home.
# Passing a template handler in the template name is deprecated. So pass the file name without the extension.
result = view.render(layout: layout, formats: [$1], file: $`)
else
body = File.read("#{@source_dir}/#{guide}")
result = RailsGuides::Markdown.new(
view: view,
layout: layout,
edge: @edge,
version: @version
).render(body)

warn_about_broken_links(result)
end

File.open(output_path, "w") do |f|
f.write(result)
end
end
Expand Down

0 comments on commit f8d346f

Please sign in to comment.