Skip to content

Commit

Permalink
A0-1262: Fix invalid variable in deploy-feature-env workflow (#625)
Browse files Browse the repository at this point in the history
Add missing env when getting value in deploy-feature-env workflow
  • Loading branch information
Mikolaj (Nicholas) Gasior authored Sep 20, 2022
1 parent 79ee98a commit 0d349f7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/actions/get-branch/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ runs:
id: get_branch
shell: bash
env:
HEAD_REF: ${{ github.head_ref }}
HEAD_REF: ${{ github.head_ref || github.ref }}
run: |
echo "##[set-output name=branch_name;]$(echo ${HEAD_REF#refs/heads/} | tr / -)"
echo "##[set-output name=branch_appname;]$(printf ${HEAD_REF#refs/head/} | tr / - | tr '[:upper:]' '[:lower:]' | tr -c '[a-z0-9-.]' '-')"
echo "##[set-output name=branch_appname;]$(printf ${HEAD_REF#refs/heads/} | tr / - | tr '[:upper:]' '[:lower:]' | tr -c '[a-z0-9-.]' '-')"
echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
6 changes: 3 additions & 3 deletions .github/workflows/deploy-feature-envs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:

- name: Build docker image with PR aleph-node binary
env:
IMAGE_TAG: ${{ FE_IMAGETAG_PREFIX }}${{ steps.get_branch.outputs.branch_imagetag_full }}
IMAGE_TAG: ${{ env.FE_IMAGETAG_PREFIX }}${{ steps.get_branch.outputs.branch_imagetag_full }}
run: |
chmod +x target/release/aleph-node
ls -alh target/release/
Expand All @@ -66,7 +66,7 @@ jobs:

- name: Push FE aleph-node image to the private feature-env-aleph-node registry
env:
IMAGE_TAG: ${{ FE_IMAGETAG_PREFIX }}${{ steps.get_branch.outputs.branch_imagetag_full }}
IMAGE_TAG: ${{ env.FE_IMAGETAG_PREFIX }}${{ steps.get_branch.outputs.branch_imagetag_full }}
run: |
docker push ${{ env.FE_ALEPHNODE_REGISTRY }}:${{ env.IMAGE_TAG }}
Expand Down Expand Up @@ -181,7 +181,7 @@ jobs:
# Generate chainspec from skeleton
docker run -v $(pwd):/app --env RUST_LOG=info ${{ env.FORKOFF_IMAGE }} --ws-rpc-endpoint=${{ env.RPC_MAINNET_URL }} --initial-spec-path=chainspec.skeleton.json --combined-spec-path=chainspec.json
aws s3 cp chainspec.json s3://${{ env.FE_KEYS_S3BUCKET }}/${{ FE_KEYS_S3PATH_PREFIX }}${{ env.BRANCH_NAME }}/chainspec.json
aws s3 cp chainspec.json s3://${{ env.FE_KEYS_S3BUCKET }}/${{ env.FE_KEYS_S3PATH_PREFIX }}${{ env.BRANCH_NAME }}/chainspec.json
aws s3 cp s3://${{ env.FE_KEYS_S3BUCKET }}/data/ s3://${{ env.FE_KEYS_S3BUCKET }}/${{ env.FE_KEYS_S3PATH_PREFIX }}${{ env.BRANCH_NAME }}/data/ --recursive
Expand Down

0 comments on commit 0d349f7

Please sign in to comment.