Fixing request data param issue. Thanks to mislav for the patch. Fixes …

…jquery#5123.
sujitra31 · Jun 15, 2010 · c90d609 · c90d609
1 parent c34a62f
commit c90d609
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/src/ajax.js b/src/ajax.js
@@ -484,7 +484,7 @@ jQuery.extend({
 
 		// Send the data
 		try {
-			xhr.send( type === "POST" || type === "PUT" || type === "DELETE" ? s.data : null );
+			xhr.send( (type !== "GET" && s.data) || null );
 
 		} catch( sendError ) {
 			jQuery.ajax.handleError( s, xhr, null, e );

diff --git a/test/data/echoData.php b/test/data/echoData.php
@@ -0,0 +1 @@
+<?php echo file_get_contents('php://input'); ?>
diff --git a/test/unit/ajax.js b/test/unit/ajax.js
@@ -1163,6 +1163,19 @@ test("data option: evaluate function values (#2806)", function() {
 	})
 });
 
+test("data option: empty bodies for non-GET requests", function() {
+	stop();
+	jQuery.ajax({
+		url: "data/echoData.php",
+		data: undefined,
+		type: "post",
+		success: function(result) {
+			equals( result, "" );
+			start();
+		}
+	})
+});
+
 test("jQuery.ajax - If-Modified-Since support", function() {
 	expect( 3 );
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		<?php echo file_get_contents('php://input'); ?>