Skip to content

Commit

Permalink
Clean up Makefile [ci skip]
Browse files Browse the repository at this point in the history
- Remove nose-cov comment: we know from requirements.txt that nose-cov is required.
- Phony targets comment: who cares? We'll just keep listing them all for now. URL still helpful.
- Coverage report comment: I don't get it. Reformat and add "XXX" to draw attention from someone who does.
  • Loading branch information
aclark4life committed Jun 7, 2015
1 parent 5f4e407 commit 70b2be6
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
# XXX Do we need all these phony targets?
.PHONY: clean coverage doc docserve help inplace install install-req release-test sdist test upload upload-test

clean:
Expand All @@ -9,12 +8,10 @@ clean:
find . -name __pycache__ | xargs rm -r || true

coverage:
# requires nose-cov
coverage erase
coverage run --parallel-mode --include=PIL/* selftest.py
nosetests --with-cov --cov='PIL/' --cov-report=html Tests/test_*.py
# doesn't combine properly before report,
# writing report instead of displaying invalid report
# XXX Doesn't combine properly before report, writing report instead of displaying invalid report.
rm -r htmlcov || true
coverage combine
coverage report
Expand All @@ -29,8 +26,8 @@ help:
@echo "Welcome to Pillow development. Please use \`make <target>' where <target> is one of"
@echo " clean remove build products"
@echo " coverage run coverage test (in progress)"
@echo " doc make html docs"
@echo " docserve run an http server on the docs directory"
@echo " doc make html docs"
@echo " docserve run an http server on the docs directory"
@echo " html to make standalone HTML files"
@echo " inplace make inplace extension"
@echo " install make and install"
Expand Down

0 comments on commit 70b2be6

Please sign in to comment.