Skip to content

Commit

Permalink
x86-32: Fix build failure with AUDIT=y, AUDITSYSCALL=n
Browse files Browse the repository at this point in the history
JONGMAN HEO reports:

  With current linus git (commit a25a2b8), I got following build error,

  arch/x86/kernel/vm86_32.c: In function 'do_sys_vm86':
  arch/x86/kernel/vm86_32.c:340: error: implicit declaration of function '__audit_syscall_exit'
  make[3]: *** [arch/x86/kernel/vm86_32.o] Error 1

OK, I can reproduce it (32bit allmodconfig with AUDIT=y, AUDITSYSCALL=n)

It's due to commit d7e7528: "Audit: push audit success and retcode
into arch ptrace.h".

Reported-by: JONGMAN HEO <[email protected]>
Signed-off-by: Al Viro <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Al Viro authored and torvalds committed Jan 18, 2012
1 parent a25a2b8 commit 6015ff1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions arch/x86/kernel/vm86_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,10 @@ static void do_sys_vm86(struct kernel_vm86_struct *info, struct task_struct *tsk
mark_screen_rdonly(tsk->mm);

/*call __audit_syscall_exit since we do not exit via the normal paths */
#ifdef CONFIG_AUDITSYSCALL
if (unlikely(current->audit_context))
__audit_syscall_exit(1, 0);
#endif

__asm__ __volatile__(
"movl %0,%%esp\n\t"
Expand Down

0 comments on commit 6015ff1

Please sign in to comment.