Skip to content

Commit

Permalink
[PATCH] ppc32: make -j12 all fails in uImage target
Browse files Browse the repository at this point in the history
make -j zImage may call if_changed twice at the same time, the result is a
corrupted vmlinux.gz

Write to a temporary file for the time being until someone with make skills
fix the serialization properly.

Signed-off-by: Olaf Hering <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Acked-by: Tom Rini <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
olafhering authored and Linus Torvalds committed Jul 13, 2005
1 parent 7ee91ec commit f13487c
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion arch/ppc/boot/images/Makefile
Original file line number Diff line number Diff line change
@@ -6,12 +6,17 @@ MKIMAGE := $(srctree)/scripts/mkuboot.sh

extra-y := vmlinux.bin vmlinux.gz

# two make processes may write to vmlinux.gz at the same time with make -j
quiet_cmd_mygzip = GZIP $@
cmd_mygzip = gzip -f -9 < $< > $@.$$$$ && mv $@.$$$$ $@


OBJCOPYFLAGS_vmlinux.bin := -O binary
$(obj)/vmlinux.bin: vmlinux FORCE
$(call if_changed,objcopy)

$(obj)/vmlinux.gz: $(obj)/vmlinux.bin FORCE
$(call if_changed,gzip)
$(call if_changed,mygzip)

quiet_cmd_uimage = UIMAGE $@
cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A ppc -O linux -T kernel \

0 comments on commit f13487c

Please sign in to comment.