Migrate all NTZ in task_log back to LTZ #660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The times in admin.materialization_status don't have timezones but are set to the current session timezone. This leads to confusion where downstream systems may interpret the time as UTC instead of the actual timezone.
This changes the fields in
INTERNAL.TASK_LOG
fromTIMESTAMP_NTZ
toTIMESTAMP_LTZ
which implicitly carry through toADMIN.MATERIALIZATION_STATUS
.To avoid weirdness of TIMESTAMP_LTZ values changes through a procedure call, this avoids passing start_time back when in FINISH_TASK. If you're curious:
There is no (easy) way to correct the data in-place. We have to do this before we release the native app with the task_log publicly; else, we will have a very bad migration problem on our hands.
Checklist: