Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix "cuda: unknown error" on Windows (#21062)
Summary: Thanks Jonas1312 for validating this workground. Fixes #20635. However, I don't know exactly why this one is needed. The following are my guesses: 1. It is a CUDA bug. Static linking against `cudart` is the default now, so they didn't run enough tests for dynamic ones. 2. It is related to UCRT. But (1)according to msdn, shared DLLs should share the same CRT. (2) The CUDA related objects like `CUDevice` passing to `cudart` are stored on the stack, not the heap. (3) If this is the case, it should always fail, not sometimes. https://docs.microsoft.com/en-us/cpp/c-runtime-library/potential-errors-passing-crt-objects-across-dll-boundaries?view=vs-2019 3. It is a bug of our side. However, I was unable to find it. Pull Request resolved: pytorch/pytorch#21062 Differential Revision: D15543557 Pulled By: ezyang fbshipit-source-id: c23af45ebf582fad93ce5f029af6e1f06cf1d49d
- Loading branch information