Skip to content

Commit

Permalink
Eclipse's Java compiler can't do type inference on this code for some…
Browse files Browse the repository at this point in the history
… reason

Workaround by adding explicit types for now.

--
PiperOrigin-RevId: 148984433
MOS_MIGRATED_REVID=148984433
  • Loading branch information
ulfjack authored and hermione521 committed Mar 2, 2017
1 parent a763ce1 commit e1475cb
Showing 1 changed file with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,16 @@ private void initialize(final Builder builder) {
requestMemoizingSupplier, topLevelSuiteNameSupplier, builderSupplier));

this.provideTestSuiteModelSupplierMemoizingSupplier =
new MemoizingSupplier<>(TestSuiteModelSupplierFactory.create(
jUnit4TestModelBuilderMemoizingSupplier));
new MemoizingSupplier<Supplier<TestSuiteModel>>(
TestSuiteModelSupplierFactory.create(jUnit4TestModelBuilderMemoizingSupplier));

this.stdoutStreamMemoizingSupplier = new MemoizingSupplier<>(StdoutStreamFactory.create());

this.optionsMemoizingSupplier =
new MemoizingSupplier<>(JUnit4OptionsFactory.create(builder.config));

this.configMemoizingSupplier =
new MemoizingSupplier<>(JUnit4ConfigFactory.create(optionsMemoizingSupplier));
new MemoizingSupplier<Object>(JUnit4ConfigFactory.create(optionsMemoizingSupplier));

this.signalHandlersSupplier =
SignalHandlersFactory.create(SignalHandlerInstallerFactory.create());
Expand All @@ -187,10 +187,11 @@ private void initialize(final Builder builder) {
StackTraceListenerFactory.create(jUnit4TestStackTraceListenerMemoizingSupplier);

this.provideXmlStreamMemoizingSupplier =
new MemoizingSupplier<>(ProvideXmlStreamFactory.create(configMemoizingSupplier));
new MemoizingSupplier<OutputStream>(
ProvideXmlStreamFactory.create(configMemoizingSupplier));

this.jUnit4TestXmlListenerMemoizingSupplier =
new MemoizingSupplier<>(JUnit4TestXmlListenerFactory.create(
new MemoizingSupplier<Object>(JUnit4TestXmlListenerFactory.create(
provideTestSuiteModelSupplierMemoizingSupplier,
cancellableRequestFactorySupplier,
signalHandlersSupplier,
Expand All @@ -203,7 +204,7 @@ private void initialize(final Builder builder) {
new MemoizingSupplier<>(CurrentRunningTestFactory.create(builder.jUnit4RunnerModule));

this.jUnit4TestNameListenerMemoizingSupplier =
new MemoizingSupplier<>(
new MemoizingSupplier<Object>(
JUnit4TestNameListenerFactory.create(provideCurrentRunningTestMemoizingSupplier));

this.nameListenerSupplier = NameListenerFactory.create(jUnit4TestNameListenerMemoizingSupplier);
Expand Down Expand Up @@ -238,7 +239,7 @@ public JUnit4Runner runner() {
}

/**
* A builder for instantiating {@ JUnit4Bazel}.
* A builder for instantiating {@link JUnit4Bazel}.
*/
public static final class Builder {
private JUnit4InstanceModules.SuiteClass suiteClass;
Expand Down

0 comments on commit e1475cb

Please sign in to comment.