-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] feat: solana basic account actions #3241
Draft
peronczyk
wants to merge
5
commits into
feat/solana-initial-structure
Choose a base branch
from
feat/solana-basic-account-actions
base: feat/solana-initial-structure
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b651d01
feat: solana possibility to add account
peronczyk 2cdaa8f
feat: solana balance fetching
peronczyk 9bf1c7c
feat: solana coin transaction list
peronczyk 373e65a
feat: solana fungible token balances
peronczyk cfc9286
refactor: solana npm packages version alignments
peronczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
<template> | ||
<IonPage> | ||
<IonContent class="account-ion-content"> | ||
<AccountDetailsBase | ||
v-if="pageDidEnter" | ||
class="account-details" | ||
> | ||
<template #navigation> | ||
<AccountDetailsNavigation | ||
:route-names="[ | ||
ROUTE_ACCOUNT_DETAILS, | ||
ROUTE_ACCOUNT_DETAILS_ASSETS, | ||
]" | ||
/> | ||
</template> | ||
</AccountDetailsBase> | ||
</IonContent> | ||
</IonPage> | ||
</template> | ||
|
||
<script lang="ts"> | ||
import { defineComponent } from 'vue'; | ||
import { IonContent, IonPage } from '@ionic/vue'; | ||
import { PROTOCOL_VIEW_ACCOUNT_DETAILS } from '@/constants'; | ||
import { ROUTE_ACCOUNT_DETAILS, ROUTE_ACCOUNT_DETAILS_ASSETS } from '@/popup/router/routeNames'; | ||
|
||
import AccountDetailsBase from '@/popup/components/AccountDetailsBase.vue'; | ||
import AccountDetailsNavigation from '@/popup/components/AccountDetailsNavigation.vue'; | ||
|
||
export default defineComponent({ | ||
name: PROTOCOL_VIEW_ACCOUNT_DETAILS, | ||
components: { | ||
AccountDetailsBase, | ||
IonPage, | ||
IonContent, | ||
AccountDetailsNavigation, | ||
}, | ||
props: { | ||
pageDidEnter: Boolean, | ||
}, | ||
setup() { | ||
return { | ||
ROUTE_ACCOUNT_DETAILS, | ||
ROUTE_ACCOUNT_DETAILS_ASSETS, | ||
}; | ||
}, | ||
}); | ||
</script> | ||
|
||
<style lang="scss" scoped> | ||
@use '@/styles/variables' as *; | ||
|
||
.account-ion-content { | ||
overflow: hidden; | ||
background-color: $color-bg-4; | ||
} | ||
</style> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CedrikNikita @martinkaintas what do you think about this way of adding our custom comments to installed packages? I feel that it might be helpful as we sometimes add packages that we need to update or change in some conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would only benefit from the approach, good suggestion.