Skip to content

Commit

Permalink
event: golint updates for this or self warning (#16631)
Browse files Browse the repository at this point in the history
* event/*: golint updates for this or self warning

* event/*: golint updates for this or self warning, pr updated per feedback
  • Loading branch information
kielbarry authored and karalabe committed May 3, 2018
1 parent fd3da7c commit 60b433a
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions event/filter/filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,37 +45,37 @@ func New() *Filters {
}
}

func (self *Filters) Start() {
go self.loop()
func (f *Filters) Start() {
go f.loop()
}

func (self *Filters) Stop() {
close(self.quit)
func (f *Filters) Stop() {
close(f.quit)
}

func (self *Filters) Notify(filter Filter, data interface{}) {
self.ch <- FilterEvent{filter, data}
func (f *Filters) Notify(filter Filter, data interface{}) {
f.ch <- FilterEvent{filter, data}
}

func (self *Filters) Install(watcher Filter) int {
self.watchers[self.id] = watcher
self.id++
func (f *Filters) Install(watcher Filter) int {
f.watchers[f.id] = watcher
f.id++

return self.id - 1
return f.id - 1
}

func (self *Filters) Uninstall(id int) {
delete(self.watchers, id)
func (f *Filters) Uninstall(id int) {
delete(f.watchers, id)
}

func (self *Filters) loop() {
func (f *Filters) loop() {
out:
for {
select {
case <-self.quit:
case <-f.quit:
break out
case event := <-self.ch:
for _, watcher := range self.watchers {
case event := <-f.ch:
for _, watcher := range f.watchers {
if reflect.TypeOf(watcher) == reflect.TypeOf(event.filter) {
if watcher.Compare(event.filter) {
watcher.Trigger(event.data)
Expand All @@ -86,10 +86,10 @@ out:
}
}

func (self *Filters) Match(a, b Filter) bool {
func (f *Filters) Match(a, b Filter) bool {
return reflect.TypeOf(a) == reflect.TypeOf(b) && a.Compare(b)
}

func (self *Filters) Get(i int) Filter {
return self.watchers[i]
func (f *Filters) Get(i int) Filter {
return f.watchers[i]
}

0 comments on commit 60b433a

Please sign in to comment.