remove console.log's and make compatible with legacy node versions

suresh44t · Nov 15, 2017 · b25d48e · b25d48e
1 parent 1a4a979
commit b25d48e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/Request.js b/lib/Request.js
@@ -12,7 +12,7 @@ var needle = require('needle'),
 
 function Request(method, url, params, opts, tries, callback) {
     var location = url;
-    var needleParams = (params && Object.keys(params).length > 0) ? params : undefined
+    var needleParams = (params && !isEmptyObject(params)) ? params : undefined
     return needle.request(method,
                           url.href,
                           needleParams,
@@ -163,4 +163,14 @@ function extend(object, donor) {
     return object;
 }
 
+function isEmptyObject(obj) {
+    if (Object.keys) return !Object.keys(obj).length;
+    for (var key in obj) {
+        if (Object.prototype.hasOwnProperty.call(obj, key)) {
+            return false;
+        }
+    }
+    return true;
+}
+
 module.exports = Request;
diff --git a/test/get.js b/test/get.js
@@ -145,7 +145,7 @@ module.exports.absentQueryString = function (assert) {
     osmosis.get(url + '/query')
     .find('div')
     .set({ content: 'p' })
-    .data((data) => {
+    .data(function (data) {
       found = true
     })
     .done(function () {
@@ -193,7 +193,6 @@ server('/test-test', function (url, req, res) {
 
 server('/query', function (url, req, res) {
     if (url.path === '/query?') {
-        console.log('empty', url)
         res.writeHead(404);
         res.end();
         return;