348 style refresh 1 #350
Merged
348 style refresh 1 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a tiny edit, and perhaps there are more little things like that. But apart from such nitpicks, on first skim these changes look great to me! Thanks for the effort. I'll let let Rovingeye and/or Vincy weigh in before merging too, but in my perception this is a good direction to take. :) |
|
Good initiative @j5v ! I made some very minor tweaks but overall, green light from me. |
VincyZed
approved these changes
Mar 19, 2024
|
@j5v Would you like me to merge this? |
I'm happy for you to merge (do I have permission to merge it myself?), and I'm always open to feedback. |
|
You'd have seen a big obvious button if you did, so no probably not. Let me see if I can give you those rights. Anyway, I merged it. :) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the tone and style for Surge XT docs, parts 01, 02, and 03.
I'm creating this PR before I'm done with the rest, to check that this is the kind of change we want as a team, and correct course if needed. Also, I might have to work on something else at short notice, so this is Agile :)
I hope this style is better for users to get what they need. Main issue is #348