qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

Today we reset fd_counter if it wraps, but it's better to abort() instead, as fd_counter should never reach INT64_MAX. Signed-off-by: Luiz Capitulino <[email protected]> Reviewed-by: Eric Blake <[email protected]> *fixed typo: s/resonable/reasonable/ Signed-off-by: Michael Roth <[email protected]>
sushihangover · Apr 2, 2013 · ce7f7cc · ce7f7cc
1 parent 9481ecd
commit ce7f7cc
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/qga/main.c b/qga/main.c
@@ -889,9 +889,13 @@ int64_t ga_get_fd_handle(GAState *s, Error **errp)
     g_assert(!ga_is_frozen(s));
 
     handle = s->pstate.fd_counter++;
-    if (s->pstate.fd_counter < 0) {
-        s->pstate.fd_counter = 0;
+
+    /* This should never happen on a reasonable timeframe, as guest-file-open
+     * would have to be issued 2^63 times */
+    if (s->pstate.fd_counter == INT64_MAX) {
+        abort();
     }
+
     if (!write_persistent_state(&s->pstate, s->pstate_filepath)) {
         error_setg(errp, "failed to commit persistent state to disk");
     }