Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tweak completions #2630

Merged
merged 2 commits into from
Dec 12, 2024
Merged

chore: tweak completions #2630

merged 2 commits into from
Dec 12, 2024
+70 −38

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Dec 12, 2024 •
edited
Loading

  • In Svelte 5, prefer onclick over on:click suggestions
  • Ignore completions in more Text positions
  • Only prefer runes/components in the script tag and in opening tags; should give more accurate completions in the template (as part of this I refactered the compiler usage a bit; it's reusable/shared between documents now)

@dummdidumm
chore: tweak completions
ad0872d 
- In Svelte 5, prefer `onclick` over `on:click` suggestions
- Ignore completions in more Text positions
- Only prefer runes/components in the script tag and in opening tags; should give more accurate completions in the template
@dummdidumm
fix test
1512e4a
@dummdidumm dummdidumm merged commit cdd3f2e into master Dec 12, 2024
3 checks passed
@dummdidumm dummdidumm deleted the completion-tweaks branch December 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dummdidumm